feat(api): replace Ignored native to use a 2d bool array #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dolly132
commented
Oct 3, 2025
Dolly132
commented
- Gets rid of the hardcoding 1d bool array and instead use 2d for client and target
- Untested
- Gets rid of the hardcoding 1d bool array and instead use 2d for client and target
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the chat ignore functionality in the CustomChatColors plugin by replacing a 1D boolean array with a 2D array for better organization and introducing a new native API function. The change improves the API design by providing granular control over ignore settings between specific client-target pairs.
Key changes:
- Replaces the hardcoded 1D boolean array
g_Ignoredwith a more intuitive 2D array structure - Introduces
CCC_SetIgnorednative function to replace the previousCCC_UpdateIgnoredArrayapproach - Updates version number from 7.4.21 to 7.4.22
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ccc.inc | Updates API definition with new CCC_SetIgnored native and increments patch version |
| CustomChatColors.sp | Implements 2D array structure and new native function with client/target validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.